RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v3]
Kevin Driver
kdriver at openjdk.org
Tue May 14 15:33:13 UTC 2024
On Thu, 9 May 2024 20:22:52 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>>
>> some code review comments
>
> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java line 59:
>
>> 57: protected String hmacAlgName;
>> 58: protected List<SecretKey> ikms;
>> 59: protected List<SecretKey> salts;
>
> Not sure if the 3 below should be `SecretKey` or `byte[]`. The latter has a benefit that when empty can be empty instead of null.
Will leave as `SecretKey`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1600247713
More information about the security-dev
mailing list