RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v55]

Kevin Driver kdriver at openjdk.org
Tue May 14 19:44:10 UTC 2024


On Tue, 14 May 2024 19:15:12 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   javadoc updates
>
> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java line 69:
> 
>> 67:     HkdfKeyDerivation(String hmacAlgName, int hmacLen,
>> 68:                       AlgorithmParameterSpec algParameterSpec)
>> 69:         throws InvalidAlgorithmParameterException {
> 
> I think you missed an earlier comment from @wangweij where this ctor should throw an IAPE if params != null.

It was on my list -- just didn't reach it yet.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1600559892



More information about the security-dev mailing list