RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v28]

[Sean Mullan]

On Tue, 14 May 2024 15:16:34 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> src/java.base/share/classes/javax/crypto/KDF.java line 314:
>> 
>>> 312:         Objects.requireNonNull(algorithm, "null algorithm name");
>>> 313:         try {
>>> 314:             Instance instance = GetInstance.getInstance("KDF", KDFSpi.class,
>> 
>> I think you can call `JceSecurity.getInstance` here, and then you don't need lines 318-322. Same comment applies to other `getInstance` methods.
>
> I think we cannot call `JceSecurity.getInstance` here, since there is an additional parameter.

Ah, ok. We should fix that and add another `JceSecurity.getInstance` method that takes an `AlgorithmParameterSpec` (but you don't need to do that as part of this change).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1600654191