RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v77]

[Sean Mullan]

On Thu, 16 May 2024 06:38:29 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   javadoc formatting
>
> src/java.base/share/classes/javax/crypto/KDF.java line 202:
> 
>> 200:      * @param provider
>> 201:      *     the provider to use for this key derivation; if null, this method is
>> 202:      *     equivalent to {@code getInstance(String)}
> 
> It might be better to disallow null here. If the code doesn't have a provider name then it would be clearer to use the 1-arg getInstance method. That would also help catch bugs where the provider name is null due to some bug.

I agree that is probably better. Our JCE APIs are somewhat inconsistent on this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1603587186