RFR: 8331975: Enable case-insensitive check in ccache and keytab entry lookup [v2]

Valerie Peng valeriep at openjdk.org
Mon May 20 22:39:09 UTC 2024


On Mon, 20 May 2024 18:38:15 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Add a new system property to control the name comparison in keytab and ccache entry lookup.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   enhance test

src/java.security.jgss/share/classes/sun/security/krb5/PrincipalName.java line 635:

> 633:         //      matched = false;
> 634:         // }
> 635:         if ((this.nameRealm != null) && (pname.nameRealm != null)) {

isn't 'nameRealm' non-null? Is this check necessary? Having this check seems to imply their value may be null and it seems incomplete that there is no code handling the cases when one or both of them are null.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19216#discussion_r1607361497



More information about the security-dev mailing list