RFR: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11

[Valerie Peng]

On Wed, 24 Apr 2024 12:24:20 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

>> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Cipher.java line 697:
>> 
>>> 695:                     k += token.p11.C_EncryptUpdate(session.id(),
>>> 696:                             0, in, inOfs, inLen,
>>> 697:                             0, out, (outOfs + k), (outLen - k));
>> 
>> Is this an actual change?
>
> @theRealAph: no, it looked to me easier to read if we have input-related parameters separated from output ones. So I did this reordering in a separate commit (0a777e94229723376e1264e87cbf0ba805dc736f), to distinguish it from the core change (in c4419bfecc0b795f6a1bdcbe5c5a6aa0142350ea).
> 
> We can revert 0a777e94229723376e1264e87cbf0ba805dc736f if it confuses more than it improves.

I prefer to not making changes like this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18898#discussion_r1612257670