[External] : Re: PEM API github repo

[Anthony Scarpino]

On 5/25/24 8:22 AM, Karl Scheibelhofer wrote:
> Hi Tony,
> 
> in https://github.com/KarlScheibelhofer/jdk/tree/pem-keystore-2-pem-api 
> you can find a PEM keystore implementation with tests. It is based on the latest https://github.com/ascarpino/jdk/tree/pem branch.
> 
> I made these two modifications 
> (https://github.com/KarlScheibelhofer/jdk/commit/4d8f3948f54c7f88791b448e047445c92e32c3d3 ) in PEMEncoder.java
> 
>   * Remove the trailing line break when encoding keys. To be
>     consistent with certificates and CRLs.
>   * Set the line length to 64 for certificates and CRLs. For consistency
>     with keys.
> 
> I did not, however include any of the feedback of 
> https://github.com/KarlScheibelhofer/jdk/commit/3551994c02ff417d8b5f0e1840d316b2514fcf4a for the PEM API. It could improve the code. What do you think.
> 
> Regards, Karl

Thanks for the comments.. I'll run through them when before I update the 
code in June

Tony