RFR: 8342183: Update tests to use stronger algorithms and keys [v4]
Rajan Halade
rhalade at openjdk.org
Fri Nov 1 15:19:29 UTC 2024
On Fri, 1 Nov 2024 13:48:45 GMT, Fernando Guallini <fguallini at openjdk.org> wrote:
>> Several tests are identified to use weak/legacy algorithms. As these tests purpose is not to exercise weak algorithms, these are updated in this PR to use stronger algorithms. If the test uses a weak key, it is updated as well.
>
> Fernando Guallini has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
>
> - Merge branch 'master' into 8342183
> - based on comments
> - Merge branch 'master' into 8342183
> - add more algos to TestExplicitKeyLength.java
> - Merge branch 'master' into 8342183
> - added changes in SecurityUtils.java and security/DiffieHellmanGroup.java
> - refactor SupportedDHParamGens.java
> - fixed SupportedDHParamGensLongKey.java
> - Updated keysizes to use SecurityUtils in KeyToolTest
> - Updated keysizes to use SecurityUtils
> - ... and 6 more: https://git.openjdk.org/jdk/compare/751a914b...081b7cd1
Marked as reviewed by rhalade (Reviewer).
Thanks for updating PR with suggested changes. The updates look good to me. I recommend to wait for another reviewer (@ascarpino ?) to approve as well.
-------------
PR Review: https://git.openjdk.org/jdk/pull/21578#pullrequestreview-2410275990
PR Comment: https://git.openjdk.org/jdk/pull/21578#issuecomment-2452051504
More information about the security-dev
mailing list