RFR: 8342442: Static ACVP sample tests [v8]

Ben Perez bperez at openjdk.org
Fri Nov 1 19:26:29 UTC 2024


On Fri, 1 Nov 2024 18:32:53 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Here we have a launcher and several algorithm-specific tests. Users can populate "internalProjection.json" files generated by NIST's ACVP Server into the `data` directory and test them with the launcher.
>> 
>> Currently, only SHA2, SHA3, ML-KEM, and ML-DSA are supported.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   rename property names, add an example

Perhaps it would be good to rename "Launcher" to "ACVP_Launcher" or "ACVP_Test" so its functionality is more explicit. Otherwise looks good

-------------

Marked as reviewed by bperez (Committer).

PR Review: https://git.openjdk.org/jdk/pull/21548#pullrequestreview-2410750916


More information about the security-dev mailing list