RFR: 8342442: Static ACVP sample tests [v8]

Weijun Wang weijun at openjdk.org
Mon Nov 4 15:16:33 UTC 2024


On Fri, 1 Nov 2024 20:03:51 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   rename property names, add an example
>
> test/jdk/sun/security/provider/acvp/Launcher.java line 78:
> 
>> 76:         //       -Dtest.acvp.alg=ML-KEM \
>> 77:         //       -Dtest.acvp.data=/path/to/json-files/ \
>> 78:         //       -jdk:/path/to/jdk Launcher.java
> 
> This seems more like either the class javadoc or the javadoc for main().  (Not an inline comment).

Moved to class level.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21548#discussion_r1827899583


More information about the security-dev mailing list