RFR: 8342442: Static ACVP sample tests [v9]

Roger Riggs rriggs at openjdk.org
Mon Nov 4 19:59:39 UTC 2024


On Mon, 4 Nov 2024 16:03:26 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Here we have a launcher and several algorithm-specific tests. Users can populate "internalProjection.json" files generated by NIST's ACVP Server into the `data` directory and test them with the launcher.
>> 
>> Currently, only SHA2, SHA3, ML-KEM, and ML-DSA are supported.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   check provider availability; SourceRandom in lib; use Utils.toByteArray

test/jdk/sun/security/provider/acvp/SHA_Test.java line 116:

> 114:                     }
> 115:                 }
> 116:                 default -> throw new UnsupportedOperationException("Unknown testType");

Including the unknown test type in the exception would speed debugging.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21548#discussion_r1828305152


More information about the security-dev mailing list