RFR: 8343622: AesDkCrypto.stringToKey should not return null [v2]

Abdelhak Zaaim duke at openjdk.org
Tue Nov 5 18:36:28 UTC 2024


On Tue, 5 Nov 2024 15:51:58 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> When an exception happens inside these stringToKey() methods, it returns a null. This would lead to unexpected NPE some time in the future.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   let it throw NSAE

Marked as reviewed by abdelhak-zaaim at github.com (no known OpenJDK username).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21908#pullrequestreview-2416413862


More information about the security-dev mailing list