RFR: 8298420: PEM API: Implementation (Preview) [v9]

[Anthony Scarpino]

On Thu, 31 Oct 2024 14:58:54 GMT, Jamil Nimeh <jnimeh at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   apparently <p> can't be before a @implNote.. Who know.
>
> src/java.base/share/classes/sun/security/pkcs/PKCS8Key.java line 143:
> 
>> 141: 
>> 142:             // OPTIONAL Context tag 0 for Attributes for PKCS8 v1 & v2
>> 143:             // Uses 0xA0 constructed define-length or 0x80 constructed
> 
> Minor nit: 0xA0 = context-specific/constructed, 0x80 = context-specific/primitive.  Definite length vs. indefinite length is not defined by the tag itself.

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1829807640