RFR: 8298390: Implementing ML-KEM key encapsulation mechanism [v15]

Kevin Driver kdriver at openjdk.org
Thu Nov 7 17:04:56 UTC 2024


On Thu, 7 Nov 2024 00:47:33 GMT, Ben Perez <bperez at openjdk.org> wrote:

>> Java implementation of ML-KEM, the [FIPS 203](https://csrc.nist.gov/pubs/fips/203/final) post-quantum KEM scheme. Depends on https://github.com/openjdk/jdk/pull/21167
>
> Ben Perez has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - default random for encaps, supported alg in SunJCE
>  - copyright header

src/java.base/share/classes/com/sun/crypto/provider/ML_KEM.java line 1151:

> 1149:     }
> 1150: 
> 1151:     // Adds the polynomials b and c to a in place, i.e. a will hold the sum.

Consider offsetting 'a' with single quotes for legibility in this comment, especially after the "i.e.".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21478#discussion_r1833042301


More information about the security-dev mailing list