RFR: 8298387: Implementing ML-DSA signature algorithm [v23]
Ben Perez
bperez at openjdk.org
Thu Nov 7 18:03:47 UTC 2024
On Tue, 8 Oct 2024 14:19:31 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> Ben Perez has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - checking already implemented
>> - no need to break into sections
>
> src/java.base/share/classes/sun/security/provider/ML_DSA_Provider.java line 109:
>
>> 107: }
>> 108:
>> 109: // TODO: check key in initSign and initVerify?
>
> Maybe you can at least check the size of the keys?
These are now checked in `implCheckPublicKey` and `implCheckPrivateKey`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21364#discussion_r1833139683
More information about the security-dev
mailing list