RFR: 8342442: Static ACVP sample tests [v12]

Sean Mullan mullan at openjdk.org
Fri Nov 8 22:15:33 UTC 2024


On Fri, 8 Nov 2024 22:08:41 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> By default, it's a no op. We will add test data files later.
>> 
>> Personally, I don't think it's worth being reported as skipped.
>
> It's pretty easy to do, you just throw `SkippedException`.

Actually what might be better is when you add the data files later, you should treat those tests as failures if you can't find the data. I'm worried about false passes, where the data file gets accidentally removed or something and the test still passes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21548#discussion_r1835107628


More information about the security-dev mailing list