RFR: 8342442: Static ACVP sample tests [v12]
Sean Mullan
mullan at openjdk.org
Sat Nov 9 18:57:00 UTC 2024
On Fri, 8 Nov 2024 22:39:25 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> Ok, I still think you should add something that knows how many data files there are, and doesn't pass unless all of them are processed/tested. I'm ok if you do that later.
>
> I'll add more info, but does not want to fail if there are unsupported algorithms.
I may not be fully understanding how the data files are structured, but I would think you should know how many tests should pass, hard-code that number into the test, and check that you get the same number of passes each time the test is run. In any case, let's revisit this comment when you start adding the data files.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21548#discussion_r1835487509
More information about the security-dev
mailing list