RFR: 8344144: AES/CBC slow at big payloads [v2]

[Volodymyr Paprotski]

On Wed, 13 Nov 2024 21:34:34 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> Volodymyr Paprotski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   comments from Kevin
>
> src/java.base/share/classes/com/sun/crypto/provider/CipherBlockChaining.java line 153:
> 
>> 151:         // chunkSize is multiple of block size, but otherwise fairly arbitrary
>> 152:         // Should be large enough to provide intrinsic with optimization
>> 153:         // oportunities
> 
> nit: type-o -> opportunities

done, thanks

> src/java.base/share/classes/com/sun/crypto/provider/CipherBlockChaining.java line 155:
> 
>> 153:         // oportunities
>> 154:         int processed = 0;
>> 155:         final int chunkSize = 1024*100;
> 
> should probably be a constant -- maybe even a system property

good point, thanks. done. If you could also please have a look at the loop boundaries. I think they are correct, but would appreciate a second (and fifth..) opinion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22086#discussion_r1841367940
PR Review Comment: https://git.openjdk.org/jdk/pull/22086#discussion_r1841369128