RFR: 8044609: javax.net.debug options not working and documented as expected [v8]

[Bradford Wetmore]

On Tue, 12 Nov 2024 11:44:48 GMT, Sean Coffey <coffeys at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/ssl/SSLLogger.java line 91:
>> 
>>> 89:         System.err.println();
>>> 90:         System.err.println("help           print the help messages");
>>> 91:         System.err.println("expand         expand debugging information");
>> 
>> Why are we tossing `expand`?  I quickly looked at the CSR, but the rationale didn't really gel.  It wasn't mentioned in the actual bug report either.  I'll look more next week.
>> 
>> Anyway, if we decide this is in the best interest of the platform, then you should also delete the `useCompactFormat` and friends in the SSLConsoleLogger.
>
> good point. I think it might have been wiped away in earlier iterations. I've added it back and added test coverage for this option. The separator logic for such options isn't specified which makes coding more tricky. I've tried to keep the syntax parsing flexible.

Maybe add a bit about what `expand` does?  

> expand       expanded (less compact) output format

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18764#discussion_r1841468538