RFR: 8298387: Implement JEP 497: Quantum-Resistant Module-Lattice-Based Digital Signature Algorithm [v8]

[Ben Perez]

On Mon, 21 Oct 2024 20:42:20 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/provider/ML_DSA_Provider.java line 33:
>> 
>>> 31: import java.util.Arrays;
>>> 32: 
>>> 33: public class ML_DSA_Provider {
>> 
>> This class isn't a `Provider`.  Can we name it something else, like`ML_DSA_Impl`?
>
> I understand what you meant, but `ML_DSA` is the actual implementation and this class is just a container of SPI child classes. It's more like a glue between the implementation and JCA. Maybe `ML_DSA_Spis`? Sounds strange but not misleading.

Changed to `ML_DSA_Impls` which mirrors the naming for the same file in the ML-KEM PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21364#discussion_r1842820330