RFR: 8298390: Implement JEP 496: Quantum-Resistant Module-Lattice-Based Key Encapsulation Mechanism [v20]

[Valerie Peng]

On Wed, 13 Nov 2024 21:12:39 GMT, Ben Perez <bperez at openjdk.org> wrote:

>> src/java.base/share/classes/com/sun/crypto/provider/ML_KEM.java line 471:
>> 
>>> 469:             }
>>> 470:         }
>>> 471:         return null;
>> 
>> Why return null? Why not just use `void` as return type? Same for the `checkPrivateKey(...)` method.
>
> This is because the `NamedKEM` methods for checking keys can optionally return the key. I can pass that key along if that makes more sense

Yes, passing the key along seems to make more sense.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21478#discussion_r1842970162