RFR: 8044609: javax.net.debug options not working and documented as expected [v9]
Sean Coffey
coffeys at openjdk.org
Tue Nov 19 14:28:43 UTC 2024
On Thu, 14 Nov 2024 00:38:23 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:
>> Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 18 commits:
>>
>> - Incorporate review comments from Brad
>> - Merge branch 'master' into 8044609-ssl
>> - keep expand option and add test coverage
>> - Copyright updates
>> - Merge branch 'master' into 8044609-ssl
>> - Merge branch 'master' into 8044609-ssl
>> - update test to comply with new debug output requirements
>> - Remove pluggability help reference
>> - Merge branch 'master' into 8044609-ssl
>> - Merge branch 'master' into 8044609-ssl
>> - ... and 8 more: https://git.openjdk.org/jdk/compare/92271af6...6cf77100
>
> src/java.base/share/classes/sun/security/ssl/SSLLogger.java line 103:
>
>> 101: System.err.println("\tdefaultctx print default SSL initialization");
>> 102: System.err.println("\tsslctx print SSLContext tracing");
>> 103: System.err.println("\tsessioncache print session cache tracing");
>
> Did the `sessioncache` category also get pulled? It used to be used whenever we added/retrieved/deleted(expired) a `SSLSession` to/from the cache. (i.e. when a handshake completed, or we are handshaking and we retrieved a session from the cache to potentially resume.)
>
> I don't see any usages of it now. If so, this is a defect and needs a bug to track.
can't see it used anywhere. I went back to an old (2007) copy of SSLSessionImpl and there it used the "ssl" category.
`private static final Debug debug = Debug.getInstance("ssl");`
No debug statements were implemented in the newer TLSv1.3 stack (to date)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18764#discussion_r1848246069
More information about the security-dev
mailing list