RFR: 8344144: AES/CBC slow at big payloads [v5]
Volodymyr Paprotski
vpaprotski at openjdk.org
Tue Nov 19 17:08:35 UTC 2024
> Measuring throughput with JMH parameters `-f 1 -i 2 -wi 3 -r 20 -w 30 -p algorithm=AES/CBC/NoPadding -p dataSize=30000000 -p provider=SunJCE -p keyLength=128 org.openjdk.bench.javax.crypto.full.AESBench`
>
> Before:
>
> Benchmark (algorithm) (dataSize) (keyLength) (provider) Mode Cnt Score Error Units
> AESBench.decrypt AES/CBC/NoPadding 30000000 128 SunJCE thrpt 2 25.383 ops/s
> AESBench.decrypt2 AES/CBC/NoPadding 30000000 128 SunJCE thrpt 2 32.230 ops/s
> AESBench.encrypt AES/CBC/NoPadding 30000000 128 SunJCE thrpt 2 20.489 ops/s
> AESBench.encrypt2 AES/CBC/NoPadding 30000000 128 SunJCE thrpt 2 21.383 ops/s
>
>
> After:
>
> Benchmark (algorithm) (dataSize) (keyLength) (provider) Mode Cnt Score Error Units
> AESBench.decrypt AES/CBC/NoPadding 30000000 128 SunJCE thrpt 2 215.144 ops/s
> AESBench.decrypt2 AES/CBC/NoPadding 30000000 128 SunJCE thrpt 2 411.265 ops/s
> AESBench.encrypt AES/CBC/NoPadding 30000000 128 SunJCE thrpt 2 64.341 ops/s
> AESBench.encrypt2 AES/CBC/NoPadding 30000000 128 SunJCE thrpt 2 73.114 ops/s
>
>
> I have not deterministically proven why chunking works: before the change, the CBC intrinsic is not being used; and after chunking, it is. There is quite a bit of GC activity in the default AESBench, so `encrypt2/decrypt2` versions isolate just crypto (see comment below).
Volodymyr Paprotski has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
- Merge remote-tracking branch 'jdk/master' into cbc-chunk
- dont change the dataSize parameter in the benchmark
- comments from Arthur and Tony
- comments from Kevin
- chunk cbc intrinsic
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/22086/files
- new: https://git.openjdk.org/jdk/pull/22086/files/5e5ef385..0be2c14a
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=22086&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=22086&range=03-04
Stats: 74746 lines in 1172 files changed: 34794 ins; 35310 del; 4642 mod
Patch: https://git.openjdk.org/jdk/pull/22086.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/22086/head:pull/22086
PR: https://git.openjdk.org/jdk/pull/22086
More information about the security-dev
mailing list