RFR: 8298390: Implement JEP 496: Quantum-Resistant Module-Lattice-Based Key Encapsulation Mechanism [v28]

Jamil Nimeh jnimeh at openjdk.org
Thu Nov 21 19:27:23 UTC 2024


On Wed, 20 Nov 2024 20:27:48 GMT, Ben Perez <bperez at openjdk.org> wrote:

>> Java implementation of ML-KEM, the [FIPS 203](https://csrc.nist.gov/pubs/fips/203/final) post-quantum KEM scheme. Depends on https://github.com/openjdk/jdk/pull/21167
>
> Ben Perez has updated the pull request incrementally with one additional commit since the last revision:
> 
>   ML_KEM no longer initialized with int

src/java.base/share/classes/com/sun/crypto/provider/ML_KEM.java line 1092:

> 1090:         for (j = 0; j < mlKem_k; j++) {
> 1091:             ntta = a[j];
> 1092:             nttb = b[j];

Do you really need ntta and nttb here?  why not just use a[j] and b[j] directly in the nttMult call?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21478#discussion_r1852667289


More information about the security-dev mailing list