RFR: 8344629: SSLSocketNoServerHelloClientShutdown test timeout [v3]

Artur Barashev abarashev at openjdk.org
Fri Nov 22 18:34:17 UTC 2024


On Fri, 22 Nov 2024 17:29:23 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

>> Artur Barashev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding CountDownLatch mechanism
>
> test/jdk/sun/security/ssl/SSLCipher/SSLSocketNoServerHelloClientShutdown.java line 74:
> 
>> 72:         float timeoutFactor = Float.parseFloat(
>> 73:                 System.getProperty("test.timeout.factor", "1.0"));
>> 74:         serverReadTimeout = (int) (30000 * timeoutFactor);
> 
> My suggestion was to remove the SoTimeout on both the client and server, also including the one now at line 95.

This is just a fallback mechanism right now, otherwise the test can hang for a very long time if something goes wrong. If 30 seconds is not enough for the test to run then we fail.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22263#discussion_r1854470354


More information about the security-dev mailing list