RFR: 8344629: SSLSocketNoServerHelloClientShutdown test timeout [v4]

Artur Barashev abarashev at openjdk.org
Tue Nov 26 12:40:37 UTC 2024


On Tue, 26 Nov 2024 01:11:00 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

>> test/jdk/sun/security/ssl/SSLCipher/SSLSocketNoServerHelloClientShutdown.java line 101:
>> 
>>> 99:                 log(e.toString());
>>> 100:             } finally {
>>> 101:                 serverLatch.countDown();
>> 
>> There should be a `latch.await()` at the `getInputStream()` above, as we want to stall the start of the server handshaking until all of the client data has been generated.  (i.e. ClientHello/Alerts X 2).
>
> You could also have a different latch here for `join`ing, but that's not as important as the one above.

I'm not sure why we need this. We have an infinite timeout now, server will read the packets from the client whenever they become available.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22263#discussion_r1858465984


More information about the security-dev mailing list