RFR: 8345057: ML_KEM NamedParameterSpec constants removed by ML-DSA integration [v2]

Hai-May Chao hchao at openjdk.org
Tue Nov 26 20:16:38 UTC 2024


On Tue, 26 Nov 2024 19:59:23 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Could someone please help review this trivial fix?
>> 
>> The constants for ML-KEM are accidentally removed during merge. This PR adds them back and adds a test for checking them against the expected ones.
>
> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   address review comments.

Marked as reviewed by hchao (Committer).

LGTM.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22397#pullrequestreview-2462585554
PR Comment: https://git.openjdk.org/jdk/pull/22397#issuecomment-2501832769


More information about the security-dev mailing list