RFR: 8345060: Remove Security Manager dependencies from java.security.KeyStore and Identity APIs and implementations

Hai-May Chao hchao at openjdk.org
Wed Nov 27 01:49:48 UTC 2024


On Tue, 26 Nov 2024 21:06:14 GMT, Sean Mullan <mullan at openjdk.org> wrote:

> Now that JEP 486 has been integrated, `java.security.KeyStore` and `Identity` API and impl dependencies on `System.getSecurityManager`, `AccessController.doPrivileged` and `AccessControlContext` can be removed.
> 
> Most of the changes are straightforward, although some of the refactoring in `KeyStore` was a bit complex due to having to extract the code from the `PrivilegedAction` subclasses.

src/java.base/share/classes/java/security/KeyStore.java line 2091:

> 2089:                     }
> 2090:                 } catch (Exception e) {
> 2091:                     oldException = e;

The updated KeyStore.java code looks good. The run0() is replaced by getKeyStore0(). Here it does not do e.getCause(), and it looks like because the exception is not wrapped by PrivilegedExceptionAction anymore?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22401#discussion_r1859637818


More information about the security-dev mailing list