RFR: 8344766: AES/CTR slow at big payloads [v2]

Jatin Bhateja jbhateja at openjdk.org
Wed Nov 27 11:47:40 UTC 2024


On Wed, 27 Nov 2024 10:58:26 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Volodymyr Paprotski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix date
>
> src/java.base/share/classes/com/sun/crypto/provider/CounterMode.java line 57:
> 
>> 55: 
>> 56:     // chunkSize is a multiple of block size and used to divide up
>> 57:     // input data to trigger the intrinsic.
> 
> This comment looks incorrect, a method marked as an intrinsic is always inline expanded by C2 compile during parsing or during incremental inlining if -XX:+InlineIncrement is used.
> 
> I guess what you intend here is triggering an OSR compilation of loop by C2 compiler which in turn trigger intrinsic since C1 never intrinsifies crypto APIs.

CRC32 message digest computation algorithm is intrinsified at C1 and interpreter level to overcome this warmup related degradation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22300#discussion_r1860515213


More information about the security-dev mailing list