RFR: 8345221: Replace legacy with new Provider APIs in SunNativeGSS
Francisco Ferrari Bihurriet
fferrari at openjdk.org
Fri Nov 29 14:57:10 UTC 2024
Hi, this pull request modifies the _SunNativeGSS_ security provider to stop using the legacy Provider APIs (`Provider::putAll`) and start using the new ones (`Provider::putService`). Additionally, it removes `sun.security.action.PutAllAction`, no longer used since #22256.
Changes in this pull request have been removed from #15539, as they aren't a dependency for that work, but just an opportunistic enhancement we made there. As a consequence, this pull request is the reverse of 29e9cba970fdbbd2192c8d2de1e93a03b1b0d1e1, the removal of this work from #15539.
#### Testing
As part of our testing, we observed all the tests pass in the following categories:
* `jdk:tier1` (see [GitHub Actions run](https://github.com/franferrax/jdk/actions/runs/12073939529))
* `jdk/java/security`
Additionally, we found no regressions with respect to the baseline (959fa4a1a35a1bb650ec5888efaf3d0fc8cfb025) in the following category:
* `jdk/sun/security`
* We obtained the same results in both codebases (the two `<reportDir>/text/summary.txt` files are identical).
| Results | |
|-------------------------|----:|
| Tests that passed | 797 |
| Tests that failed | 16 |
| Tests that had errors | 2 |
| Tests that were not run | 35 |
| Total | 850 |
* In particular, the tests that enable the _SunNativeGSS_ security provider, all passed:
* [jdk/sun/security/jgss/GssContextCleanup.java](https://github.com/openjdk/jdk/blob/959fa4a1a35a1bb650ec5888efaf3d0fc8cfb025/test/jdk/sun/security/jgss/GssContextCleanup.java#L48)
* [jdk/sun/security/jgss/GssNameCleanup.java](https://github.com/openjdk/jdk/blob/959fa4a1a35a1bb650ec5888efaf3d0fc8cfb025/test/jdk/sun/security/jgss/GssNameCleanup.java#L47)
* [jdk/sun/security/krb5/auto/BasicProc.java](https://github.com/openjdk/jdk/blob/959fa4a1a35a1bb650ec5888efaf3d0fc8cfb025/test/jdk/sun/security/krb5/auto/BasicProc.java#L276)
* [jdk/sun/security/krb5/auto/Cleaners.java](https://github.com/openjdk/jdk/blob/959fa4a1a35a1bb650ec5888efaf3d0fc8cfb025/test/jdk/sun/security/krb5/auto/Cleaners.java#L176)
* [jdk/sun/security/krb5/auto/ReplayCacheTestProc.java](https://github.com/openjdk/jdk/blob/959fa4a1a35a1bb650ec5888efaf3d0fc8cfb025/test/jdk/sun/security/krb5/auto/ReplayCacheTestProc.java#L389)
* [jdk/sun/security/krb5/runNameEquals.sh](https://github.com/openjdk/jdk/blob/959fa4a1a35a1bb650ec5888efaf3d0fc8cfb025/test/jdk/sun/security/krb5/runNameEquals.sh#L99)
This contribution is co-authored by @franferrax and @martinuy.
-------------
Commit messages:
- 8345221: Replace legacy with new Provider APIs in SunNativeGSS
Changes: https://git.openjdk.org/jdk/pull/22461/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22461&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8345221
Stats: 71 lines in 2 files changed: 3 ins; 59 del; 9 mod
Patch: https://git.openjdk.org/jdk/pull/22461.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/22461/head:pull/22461
PR: https://git.openjdk.org/jdk/pull/22461
More information about the security-dev
mailing list