RFR: 8339403: sun.security.ssl.StatusResponseManager.get swallows interrupt status [v2]

Valerie Peng valeriep at openjdk.org
Thu Oct 3 16:58:39 UTC 2024


On Wed, 2 Oct 2024 22:53:01 GMT, Jamil Nimeh <jnimeh at openjdk.org> wrote:

>> This PR corrects a flaw in the StatusResponseManager where it was incorrectly swallowing the interrupt status when either an invokeAll was called (spawning the threads to fetch each OCSP response) or when attempting to grab the data from one of the Futures returned from the fetches.
>> Additionally, I made a small change that, in the unlikely event of a non-IOException being thrown, only that specific fetch is affected, but other successful fetches on different threads can complete and can be added to the resulting responseMap.
>
> Jamil Nimeh has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Add continue at end of ExecutionException catch block
>  - Merge with main
>  - 8339403: sun.security.ssl.StatusResponseManager.get swallows interrupt status

Marked as reviewed by valeriep (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21230#pullrequestreview-2346146023


More information about the security-dev mailing list