RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v6]

Sean Mullan mullan at openjdk.org
Thu Oct 3 19:57:35 UTC 2024


On Thu, 3 Oct 2024 19:44:25 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/x509/NamedX509Key.java line 48:
>> 
>>> 46:     private final byte[] h;
>>> 47: 
>>> 48:     /// Ctor from family name, parameter set name, raw key bytes.
>> 
>> Any reason you use 3 slashes instead of 2 for comments?
>
> I'm trying out the https://openjdk.org/jeps/467 style javadoc. Still, this is not public API so I can take the risk for the experiment.

Ok, but how are you experimenting? These comments aren't using any markdown that I can see, and it's rare that we would generate javadoc for internal classes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21167#discussion_r1786773600


More information about the security-dev mailing list