RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v9]

[Sean Mullan]

On Mon, 7 Oct 2024 12:51:56 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are only named standardized parameter sets, a common framework is introduced.
>> 
>> A example of EdDSA implementation using this framework is included as a test.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   no need for this when there is no ambiguity

src/java.base/share/classes/sun/security/provider/NamedKEM.java line 72:

> 70:             throws InvalidAlgorithmParameterException, InvalidKeyException {
> 71:         if (spec != null) {
> 72:             throw new InvalidAlgorithmParameterException("No params needed");

Could you make this message more helpful? Ex: "The ML-KEM-768 algorithm does not take any parameters", where "ML-KEM-768" is the alg+param name in use (may need a new protected method to obtain that).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21167#discussion_r1790578896