RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v10]

[Weijun Wang]

On Tue, 8 Oct 2024 19:16:10 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   null check as asserts, and better exception messages
>
> src/java.base/share/classes/sun/security/provider/NamedSignature.java line 146:
> 
>> 144:     @SuppressWarnings("deprecation")
>> 145:     protected Object engineGetParameter(String param) throws InvalidParameterException {
>> 146:         throw new UnsupportedOperationException("getParameter() not supported");
> 
> `engineGetParameter` is not specified to throw UOE, so suggest throwing `InvalidParameterException` instead. Same comment for `engineSetParameter`.

Yes I will. I noticed that the newest implementation `HSS` does throw `InvalidParameterException`, and a little older one `ECDSASignature` and `EdDSASignature` were throwing `UnsupportedOperationException`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21167#discussion_r1792463680