RFR: 8298420: PEM API: Implementation (Preview) [v6]

[Kevin Driver]

On Wed, 25 Sep 2024 18:50:55 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> Hi all,
>> 
>> I need a code review of the PEM API.  Privacy-Enhanced Mail (PEM) is a format for encoding and decoding cryptographic keys and certificates.  It will be integrated into JDK24 as a Preview Feature.  Preview features does not permanently define the API and it is subject to change in future releases until it is finalized.
>> 
>> Details about this change can be seen at [PEM API JEP](https://bugs.openjdk.org/browse/JDK-8300911).
>> 
>> Thanks
>> 
>> Tony
>
> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix decoding non-encrypted types

src/java.base/share/classes/sun/security/x509/AlgorithmId.java line 1:

> 1: /*

Consider undoing the diff/change to remove the newline, or technically, you'll need to update the copyright year, I suppose.

src/java.base/share/classes/sun/security/x509/X509Key.java line 1:

> 1: /*

Update copyright year, if required.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1794116718
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1794117697