RFR: 8298387: Implementing ML-DSA signature algorithm [v3]

[Ben Perez]

On Tue, 8 Oct 2024 14:25:40 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Ben Perez has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   renamed internal keyGen/sign/verify functions to be same as spec
>
> src/java.base/share/classes/sun/security/provider/ML_DSA.java line 545:
> 
>> 543:         int[][] s1 = Arrays.stream(sk.s1()).map(int[]::clone).toArray(int[][]::new);
>> 544:         int[][] s2 = Arrays.stream(sk.s2()).map(int[]::clone).toArray(int[][]::new);
>> 545:         int[][] t0 = Arrays.stream(sk.t0()).map(int[]::clone).toArray(int[][]::new);
> 
> Instead of calling `mlDsa.skDecode(skBytes)` in `ML_DSA_Provider`, can we move the call here? Then `sk` becomes a local variable and you probably don't need to make the deep clones above.

Moved all key decoding calls to the internal ML-KEM methods

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21364#discussion_r1795726061