RFR: 8298420: PEM API: Implementation (Preview) [v6]

[Anthony Scarpino]

On Wed, 9 Oct 2024 18:52:32 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix decoding non-encrypted types
>
> src/java.base/share/classes/java/security/PEMDecoder.java line 91:
> 
>> 89: 
>> 90:     /**
>> 91:      * Creates a immutable instance with a specific KeyFactory and/or password.
> 
> I suggest: "Creates an immutable instance with a specific {@code KeyFactory} provider and/or password."

If this was a public comment, I would agree.  However, this is a private constructor comment.

> src/java.base/share/classes/java/security/PEMDecoder.java line 92:
> 
>> 90:     /**
>> 91:      * Creates a immutable instance with a specific KeyFactory and/or password.
>> 92:      * @param withFactory KeyFactory provider
> 
> Should `KeyFactory` be surrounded by `{@code}`?

If this was a public comment, I would agree.  However, this is a private constructor comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1795946527
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1795946647