RFR: 8298420: PEM API: Implementation (Preview) [v6]

[Anthony Scarpino]

On Wed, 9 Oct 2024 18:54:48 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> src/java.base/share/classes/java/security/PEMDecoder.java line 93:
>> 
>>> 91:      * Creates a immutable instance with a specific KeyFactory and/or password.
>>> 92:      * @param withFactory KeyFactory provider
>>> 93:      * @param withPassword char[] password for EncryptedPrivateKeyInfo
>> 
>> Should `EncryptedPrivateKeyInfo` be surrounded by `{@code}`?
>
> Also, I suggest something to the effect of "the char array is cloned to prevent subsequent modification"

If this was a public comment, I would agree.  However, this is a private constructor comment.
Though mentioning the cloning may not be a bad idea

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1795947517