RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v58]

[Kevin Driver]

On Tue, 15 Oct 2024 22:55:17 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   running the Exhaustive test through a more ruthless formatter
>
> test/jdk/com/sun/crypto/provider/KDF/HKDFExhaustiveTest.java line 298:
> 
>> 296:     Utils.runAndCheckException(
>> 297:         () -> KDF.getInstance(KDF_ALGORITHMS[0], (KDFParameters) new KDFAlgorithmParameterSpec()),
>> 298:         ClassCastException.class);
> 
> The ClassCastException is the result of line 297? I don't see the reason for testing this, seems nothing to do with the KDF impls?

@rhalade : can you comment on your test?

> test/jdk/com/sun/crypto/provider/KDF/HKDFExhaustiveTest.java line 328:
> 
>> 326:                 (KDFParameters) new KDFAlgorithmParameterSpec(),
>> 327:                 SUNJCE_PROVIDER),
>> 328:         ClassCastException.class);
> 
> Same comment regarding the ClassCastException here.

@rhalade : can you comment on your test?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1802119561
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1802119773