RFR: 8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree

[Rajan Halade]

On Wed, 23 Oct 2024 14:46:37 GMT, Fernando Guallini <fguallini at openjdk.org> wrote:

> The test sun/security/pkcs11/Provider/RequiredMechCheck.java extends sun/security/pkcs11/PKCS11Test.java, which sets up a PKCS11Provider configured with NSS config files located in the source tree directory (sun/security/pkcs11/nss) for the dependent tests to run properly. This test currently fails if that **pkcs11/nss** directory is made read-only because these config files are updated during the test execution. Files located in the source tree should not be modified when running tests. 
> This PR updates the PKCS11Test to copy the NSS config files to the Jtreg scratch directory and configures the provider to use those files instead.

Changes requested by rhalade (Reviewer).

test/jdk/sun/security/pkcs11/PKCS11Test.java line 250:

> 248:     }
> 249: 
> 250:     private static void copyFiles(Path source, String destination)

Check jdk.test.lib if there is a method you can use to copy files. If not then this method should be added to library.

test/jdk/sun/security/pkcs11/PKCS11Test.java line 526:

> 524:         String nss = "nss";
> 525:         Path nssDirSource = Path.of(base).resolve(nss);
> 526:         String nssDirDestination = Path.of(".").resolve(nss).toString();

Using current directory here may be incorrect. Can this be changed to `Path.of(System.getProperty("test.classes"), ".")`

-------------

PR Review: https://git.openjdk.org/jdk/pull/21665#pullrequestreview-2390093528
PR Review Comment: https://git.openjdk.org/jdk/pull/21665#discussion_r1813442710
PR Review Comment: https://git.openjdk.org/jdk/pull/21665#discussion_r1813443826