RFR: 8317538: potential bottleneck in Provider::getService: specjvm2008::crypto.rsa have scalability issue for high vCPU numbers

[Anthony Scarpino]

On Mon, 21 Oct 2024 18:18:12 GMT, Vladimir Ivanov <vaivanov at openjdk.org> wrote:

> This patch remove access to the shared variable to fix scalability issue in the multithread environment.  According to testing by the specjvm2008::crypto.rsa the one thread performance reduced for less than 1% while the score for the multithread run increased in ~2x. For the 2 socket system with Xeon 8480+ numbers looks as: 
> - 1 thread: 643.15 for original version vs 642.54 for patched one;
> - 224 threads: 22446.19 for original vs 46147.41 for patched.
> 
> The RSABench microbenchmark reports no score changes for the 1 thread (average for all testcases) and 2.4% improvement for the 224 threads.

Is `volatile` a known performance decelerator?
I don't see any source control history for that part of the code, so I can only speculate at `previousKey` was to improve benchmarking.  Did you try just removing `volatile` and leaving the rest of the code?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21622#issuecomment-2436074968