RFR: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server [v24]

Artur Barashev abarashev at openjdk.org
Mon Oct 28 17:57:51 UTC 2024


On Fri, 25 Oct 2024 19:45:00 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:

>> Artur Barashev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 28 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8331682
>>  - Use more appropriate exception with the alert description
>>  - Update Copyright
>>  - Update @library directive
>>  - Merge branch 'master' into JDK-8331682
>>  - Produce appropriate exception message. Update tests.
>>  - Adjust line length
>>  - Additional error checking
>>  - Write and read to/from server in a single pass. Use SocketChannel.
>>  - Return null if there is no record we attempted to decode
>>  - ... and 18 more: https://git.openjdk.org/jdk/compare/c7acc56c...aef08dd0
>
> test/lib/jdk/test/lib/security/SecurityUtils.java line 144:
> 
>> 142:             int contentLen = getInt16(packet);                 // pos: 3, 4
>> 143: 
>> 144:             System.err.printf(
> 
> If you keep, <= 80 chars

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21043#discussion_r1819506910


More information about the security-dev mailing list