RFR: 8342183: Update tests to use stronger algorithms and keys
Matthew Donovan
mdonovan at openjdk.org
Tue Oct 29 09:54:44 UTC 2024
On Thu, 24 Oct 2024 09:49:39 GMT, Fernando Guallini <fguallini at openjdk.org> wrote:
>> test/jdk/com/sun/crypto/provider/KeyAgreement/SupportedDHParamGens.java line 61:
>>
>>> 59:
>>> 60: static DHParameterSpec FFDHE4096_SPEC = new DHParameterSpec(
>>> 61: dhGroup4096.getPrime(), dhGroup4096.getBase());
>>
>> It looks like the DiffieHelmanGroup fields are just used to intialize the DHParameterSpec. It might be cleaner to create the DHParameterSpec objects in a static initializer.
>>
>> Also, the DHParameterSpec objects can be `final`
>
> Actually, these vars are not needed, simplified with latest commit.
looks good to me
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21578#discussion_r1815142923
More information about the security-dev
mailing list