RFR: 8298420: PEM API: Implementation (Preview) [v9]

[Weijun Wang]

On Mon, 21 Oct 2024 19:52:36 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> Hi all,
>> 
>> I need a code review of the PEM API.  Privacy-Enhanced Mail (PEM) is a format for encoding and decoding cryptographic keys and certificates.  It will be integrated into JDK24 as a Preview Feature.  Preview features does not permanently define the API and it is subject to change in future releases until it is finalized.
>> 
>> Details about this change can be seen at [PEM API JEP](https://bugs.openjdk.org/browse/JDK-8300911).
>> 
>> Thanks
>> 
>> Tony
>
> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
> 
>   apparently <p> can't be before a @implNote.. Who know.

src/java.base/share/classes/java/security/PEMDecoder.java line 316:

> 314:                 if ((PKCS8EncodedKeySpec.class).isAssignableFrom(tClass)) {
> 315:                     getKeyFactory(key.getAlgorithm()).
> 316:                         getKeySpec(key, PKCS8EncodedKeySpec.class);

Did you forget to assign above to `so`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1821358146