RFR: 8298420: PEM API: Implementation (Preview) [v9]

Weijun Wang weijun at openjdk.org
Tue Oct 29 18:37:13 UTC 2024


On Tue, 30 Jul 2024 19:11:53 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> If it isn't used anywhere, then it's probably from an old idea that I didn't completely clean up
>
> This constructor is eventually used by PEMEncoder for KeyPair.   Yes if the private key encoding did have a public key already it would be overwritten; however, the API usage is to combine the given KeyPair into PEM text.  The expected usage is after generating a KeyPair.
> As far as preventing an overwrite, while it can probably be done, I don't see the value in adding a check at this point.

I see. Good.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1821356385


More information about the security-dev mailing list