RFR: 8341927: Replace hardcoded security providers with new test.provider.name system property [v6]
Sean Mullan
mullan at openjdk.org
Wed Oct 30 16:48:15 UTC 2024
On Wed, 30 Oct 2024 14:48:46 GMT, Matthew Donovan <mdonovan at openjdk.org> wrote:
>> In this PR, I removed hard-coded security providers and replaced them with a system property, test.provider.name. If the property is not specified, the provider originally used in the test is used:
>>
>> Cipher c = Cipher.getInstance("AES/GCM/NoPadding", System.getProperty("test.provider.name", "SunJCE"));
>
> Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision:
>
> updated testing doc per PR comments
doc/testing.html line 597:
> 595: <code>KeyFactory</code>, <code>Cipher</code>,
> 596: <code>KeyPairGenerator</code>, <code>KeyGenerator</code>, or
> 597: <code>SecretKeyFactory</code> objects. Specify the
I see some tests use a hard-coded provider for `Signature` too. Can you double-check all the changes and add any that you missed?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21551#discussion_r1823022778
More information about the security-dev
mailing list