RFR: 8298420: PEM API: Implementation (Preview) [v9]

Anthony Scarpino ascarpino at openjdk.org
Thu Oct 31 00:26:35 UTC 2024


On Wed, 30 Oct 2024 20:11:46 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   apparently <p> can't be before a @implNote.. Who know.
>
> src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java line 84:
> 
>> 82:      * @param encoded the ASN.1 encoding to be parsed.
>> 83:      * @throws NullPointerException if {@code encoded} is {@code null}.
>> 84:      * @throws IOException if error occurs when parsing the ASN.1 encoding.
> 
> Why change the old spec? There seems to be no problem. Especially, why remove the "array are copied" sentence?

I can re-add the cloning.  As far as the others, `parses` was implied by `from an ASN.1 encoding.` and I thought being more specific about what type of ASN.1 encoding was better

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1823624089


More information about the security-dev mailing list