RFR: 8342442: Static ACVP sample tests [v3]

[Mark Powers]

On Thu, 31 Oct 2024 17:21:06 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Here we have a launcher and several algorithm-specific tests. Users can populate "internalProjection.json" files generated by NIST's ACVP Server into the `data` directory and test them with the launcher.
>> 
>> Currently, only SHA2, SHA3, ML-KEM, and ML-DSA are supported.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   license

This looks good to me. Only a few grammatical changes. Why the inclusion of SHA?

test/jdk/sun/security/provider/acvp/Launcher.java line 61:

> 59:         // The test walks through the directory recursively and looks for
> 60:         // file names equals to or ends with "internalProjection.json" and
> 61:         // run test on it. Only very limited algorithms are supported.

s/ends/ending/
s/run/runs/

test/jdk/sun/security/provider/acvp/Launcher.java line 70:

> 68:         // registered.
> 69:         //
> 70:         // Tests are including in this directory and each must implement

s/including/included/

-------------

PR Review: https://git.openjdk.org/jdk/pull/21548#pullrequestreview-2408760083
PR Review Comment: https://git.openjdk.org/jdk/pull/21548#discussion_r1824966727
PR Review Comment: https://git.openjdk.org/jdk/pull/21548#discussion_r1824969420