RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v15]

Weijun Wang weijun at openjdk.org
Tue Sep 3 22:17:37 UTC 2024


On Fri, 30 Aug 2024 21:44:44 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> This is not an API comment. This is implementation only.
>> 
>> I just propose that if there exist one or more implementations for this algorithm but none of them accepts the parameters then you should throw an IAPE. This is what the spec is saying.
>
> Addressed in https://github.com/openjdk/jdk/pull/20301/commits/e4400b6edaf69d08726a63e2a705784c731648db. Please confirm if resolved.

In the `catch (NoSuchAlgorithmException e)` block, you assign a brand new exception to `lastException` and info in `e` is lost. What does `e` look like? Can you directly assign it to `lastException`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1742765522


More information about the security-dev mailing list