RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v15]

Weijun Wang weijun at openjdk.org
Tue Sep 3 22:21:33 UTC 2024


On Fri, 30 Aug 2024 21:44:26 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 157:
>> 
>>> 155:          * <p>
>>> 156:          * This supports the use-case where a label can be applied to the IKM
>>> 157:          * but the actual value of the IKM is not yet available.
>> 
>> I feel the two paragraphs above are repeated too many times. Better describe them in the class spec.
>
> Addressed in https://github.com/openjdk/jdk/pull/20301/commits/e4400b6edaf69d08726a63e2a705784c731648db. Please confirm if resolved.

I'll read the whole class again.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1742768413


More information about the security-dev mailing list